ProcessOnly feature / patch

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

ProcessOnly feature / patch

Eric B.-2
The concept for this feature / patch is to be able to install ASSP in a
production environment, but only enable it for certain users/domains while
it is being trained/tweaked so that it doesn't affect everyone's email.  
That way it gives the option of creating a group of beta-testers/users that
can still run on the live system (my MTA doesn't have the ability to
redirect connections destined for specific users to other machines/ports).  
I have coded the option much neater and more simple than my original
attempt.  This patch is against build 47.  Please take a look at it and let
me know what you think.

It is a very general setting.  It piggy-backs on all the no-processing code.
  But it doesn't exclude the noproc settings - any noproc setting takes
precendence over the list.  If a user is listed on both the ProcessOnly and
the NoProcessing lists, the NoProcessing takes precedence.   It might still
be too general, or might be something useful that others may want.  I
included the options in the NoProcessing section, b/c I didn't know where
else to put them, but I figured someone else might be in a better position
to determine where they might go.


I also have a quick question...  On line 3165, there is the following code:
    if ($noProcessing) {
      if("$u$h"=~$NPREL) { $this->{noprocessing}|=1 } else {
$this->{noprocessing}|=2 }
    }

Nowhere else in the code is the noprocessing flag set as a bit field (or
used to compare against a bit field), so I can't figure out why this is here
like this.  In fact, everwhere else in the code looks for;
if( $this->{noprocessing} == 1 ).  Never does it check if the first bit is
set.  Is this just some remnants of old code?  I would have expected this
line to be:
    if ($noProcessing) {
      if("$u$h"=~$NPREL) { $this->{noprocessing}=1 }
    }


Please let me know if this feature is worthwhile.  I plan to use it while
ramping up my own production site to make sure that things are running
smoothly without adversely affecting non-beta users' emails.

Eric

_________________________________________________________________
Not only does WindowsOff to school, going on a trip, or moving? Windows Live
(MSN) Messenger lets you stay in touch with friends and family wherever you
go. Click here to find out how to sign up!  Live™ OneCare™ provide
all-in-one PC care to keep your computer protected and well-maintained, but
it also makes creating backup files a breeze. Try it today!
http://www.telusmobility.com/msnxbox/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Assp-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/assp-devel

proconly.patch (4K) Download Attachment